Skip to content

Make Worker only if module uses the transition - #51634

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:optimizeStreamRunLumi
Aug 6, 2026
Merged

Make Worker only if module uses the transition#51634
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:optimizeStreamRunLumi

Conversation

@Dr15Jones

@Dr15Jones Dr15Jones commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR description:

If a module doesn't process a stream Run or LuminosityBlock transition then we no longer make a Worker for that transition.

PR validation:

Code compiles and all framework unit tests pass.

resolves cms-sw/framework-team#2378

If a module doesn't process a stream Run or LuminosityBlock transition then we no longer make a Worker for that transition.
@Dr15Jones

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51634/50469

@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/Framework (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c34822/55109/summary.html
COMMIT: c3a08d2
CMSSW: CMSSW_20_1_X_2026-08-05-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51634/55109/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c34822/55109/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c34822/55109/git-merge-result

Comparison Summary

Summary:

  • You potentially added 62 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 56 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3588770
  • DQMHistoTests: Total failures: 18959
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3569790
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 92.735 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 34434.0,... ): 15.791 KiB HGCAL/BranchValidator
  • DQMHistoSizes: changed ( 34434.0,... ): 2.732 KiB Tracking/BranchValidator
  • DQMHistoSizes: changed ( 34434.0,... ): 0.012 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 34434.0,... ): 0.012 KiB MessageLogger/Warnings
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: found differences in 5 / 44 workflows

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 6 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step1 max memory diff 63.2 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.75_TTbar_14TeV+Run4D121_HLT75e33Timing step1 max memory diff 63.2 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step1 max memory diff 65.9 exceeds +/- 30.0 MiB
  • Error: Workflow 34634.0_TTbar_14TeV+Run4D121PU step3 max memory diff 411.5 exceeds +/- 30.0 MiB
  • Error: Workflow 34634.0_TTbar_14TeV+Run4D121PU step2 max memory diff 537.1 exceeds +/- 30.0 MiB
  • Error: Workflow 34634.0_TTbar_14TeV+Run4D121PU step1 max memory diff 63.2 exceeds +/- 30.0 MiB

@makortel

makortel commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Changes look fine, but I'd like to run the tests again in the next IB to have clean comparisons

@makortel

makortel commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild, please test

@cmsbuild

cmsbuild commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c34822/55134/summary.html
COMMIT: c3a08d2
CMSSW: CMSSW_20_1_X_2026-08-06-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51634/55134/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3589140
  • DQMHistoTests: Total failures: 50
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3589072
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@makortel

makortel commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Comparison differences are related to #47071 and #51594

@makortel

makortel commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

+core

@cmsbuild

cmsbuild commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit da58d92 into cms-sw:master Aug 6, 2026
10 checks passed
@Dr15Jones
Dr15Jones deleted the optimizeStreamRunLumi branch August 13, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Worker only if module uses the transition

4 participants